Merged
Conversation
The following test files were added in recent PRs but not included in MANIFEST, meaning they would be absent from the CPAN distribution tarball: - t/coverage_gaps.t (PR #248) - t/expat_xs_coverage.t (PR #249) - t/parser_api.t (PR #244) - t/stream_delimiter.t (PR #243) Also extend MANIFEST.SKIP with standard exclusions for build artifacts (blib/, *.o, *.so, *.bs, *.c), coverage data (cover_db/), and OS files (.DS_Store) to prevent future regenerations from picking up stale files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
=======================================
Coverage 75.73% 75.73%
=======================================
Files 1 1
Lines 1092 1092
Branches 342 342
=======================================
Hits 827 827
Misses 59 59
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add 4 test files to MANIFEST that were missing from the CPAN distribution, and improve MANIFEST.SKIP with standard exclusions.
Why
These test files were added in merged PRs (#243, #244, #248, #249) but MANIFEST wasn't regenerated. Running
make distwould create a tarball without these tests — CPAN Testers and end users would never run them.How
make manifestafter cleaning build artifacts to regenerate MANIFESTblib/,*.o,*.so,*.bs,*.c,cover_db/,.DS_Store, andMakefile.oldto keep future regenerations cleanTesting
make test— all tests passmake disttest— distribution builds and tests correctly with all 59 test files included🤖 Generated with Claude Code